Bug Report: m4/issm_options.m4

iamparkchan

When I ./configure, it produced error message.

configure: error: Python.h not found, locate this file and contact ISSM developers

In my environment, Python.h's actual location is /foo/bar/python/include/python3.7m.

In the m4/issm_options.m4 file, there is code corresponding to my situation as follows:

 634                 else if test -f "$PYTHON_ROOT/include/python$PYTHON_VERSIONm/Python.h"; then
 635                         PYTHONINCL=-I$PYTHON_ROOT/include/python$PYTHON_VERSIONm

However, I think it should be

 634                 else if test -f "$PYTHON_ROOT/include/python${PYTHON_VERSION}m/Python.h"; then
 635                         PYTHONINCL=-I$PYTHON_ROOT/include/python${PYTHON_VERSION}m

to work properly.

mathieumorlighem

Hi @iamparkchan

thanks for letting us know, this could definitely be a bug. Did you try to implement that change, run "autoreconf -ivf" and configure to see if that fixes your problem?
Thanks
Mathieu

iamparkchan

mathieumorlighem

I confirm that the implementation fixes my problem.

justinquinn

iamparkchan

Thank you for bringing this to our attention. This file (and probably others) have needed some attention for some time now. I am currently performing a clean up, and it will be incorporated into our next public release.

Best,
Justin

iamparkchan

justinquinn

I also mention about m4/issm_options.m4 file.
For Python3,

PYTHON_VERSION=$($PYTHON_ROOT/bin/python -c "import sys; print sys.version[[:3]]")

does not work. It should be modified

PYTHON_VERSION=$($PYTHON_ROOT/bin/python -c "import sys; print(sys.version[[:3]])")

adding parentheses to print function.