source: issm/oecreview/Archive/24307-24683/ISSM-24537-24538.diff@ 24684

Last change on this file since 24684 was 24684, checked in by Mathieu Morlighem, 5 years ago

CHG: added new review

File size: 7.1 KB
RevLine 
[24684]1Index: ../trunk-jpl/src/m/qmu/preqmu.m
2===================================================================
3--- ../trunk-jpl/src/m/qmu/preqmu.m (revision 24537)
4+++ ../trunk-jpl/src/m/qmu/preqmu.m (revision 24538)
5@@ -23,16 +23,16 @@
6 iparams = getfieldvalue(options,'iparams',1);
7
8 %first create temporary directory in which we will work
9-if strncmpi(overwrite,'y',1)
10- system(['rm -rf ' qmudir '/*']);
11-else
12- %does the directory exist? if so, then error out
13- if exist(qmudir)==7,
14- error('Existing ''%s'' directory, cannot overwrite. Specify ''overwrite'',''y'' option in solve arguments.',options.qmudir);
15- end
16-end
17-mkdir(qmudir)
18-cd(qmudir)
19+%if strncmpi(overwrite,'y',1)
20+% system(['rm -rf ' qmudir '/*']);
21+%else
22+% %does the directory exist? if so, then error out
23+% if exist(qmudir)==7,
24+% error('Existing ''%s'' directory, cannot overwrite. Specify ''overwrite'',''y'' option in solve arguments.',options.qmudir);
25+% end
26+%end
27+%mkdir(qmudir)
28+%cd(qmudir)
29
30 %when running in library mode, the in file needs to be called md.miscellaneous.name.qmu.in
31 qmufile=[md.miscellaneous.name ];
32@@ -45,7 +45,7 @@
33 variables=expandvariables(md,variables);
34 responses=expandresponses(md,responses);
35
36-%go through variables and responses, and check they don't have more than md.qmu.numberofpartitions values. Also determine numvariables and numresponses{{{
37+%go through variables and responses, and check they don't have more than md.qmu.numberofpartitions values. Also determine numvariables and numresponses
38 numvariables=0;
39 variable_fieldnames=fieldnames(variables);
40 for i=1:length(variable_fieldnames),
41@@ -71,13 +71,12 @@
42 end
43 numresponses=numresponses+numel(responses.(field_name));
44 end
45-%}}}}
46
47 %create in file for dakota
48 dakota_in_data(md.qmu.method(imethod),variables,responses,md.qmu.params(iparams),qmufile);
49 system(['rm -rf ' md.miscellaneous.name '.m']);
50
51-%build a list of variables and responses descriptors. the list is not expanded. {{{
52+%build a list of variables and responses descriptors. the list is not expanded.
53 variabledescriptors={};
54 variable_fieldnames=fieldnames(md.qmu.variables(ivar));
55 for i=1:length(variable_fieldnames),
56@@ -97,7 +96,6 @@
57 responsedescriptors{end+1}=fieldresponses(j).descriptor;
58 end
59 end
60-%}}}
61
62 %register the fields that will be needed by the Qmu model.
63 md.qmu.numberofresponses=numresponses;
64Index: ../trunk-jpl/src/m/qmu/process_qmu_options.m
65===================================================================
66--- ../trunk-jpl/src/m/qmu/process_qmu_options.m (revision 24537)
67+++ ../trunk-jpl/src/m/qmu/process_qmu_options.m (revision 24538)
68@@ -73,8 +73,6 @@
69 iparams=options{i,2};
70 case 'overwrite'
71 outoptions.overwrite=options{i,2};
72- case 'keep'
73- outoptions.keep=options{i,2};
74 case 'outfiles'
75 outoptions.outfiles=options{i,2};
76 case 'rstfile'
77Index: ../trunk-jpl/src/m/solve/solveiceocean.m
78===================================================================
79--- ../trunk-jpl/src/m/solve/solveiceocean.m (revision 24537)
80+++ ../trunk-jpl/src/m/solve/solveiceocean.m (revision 24538)
81@@ -134,10 +134,3 @@
82 elseif md.settings.waitonlock==0,
83 disp('Model results must be loaded manually with md=loadresultsfromcluster(md);');
84 end
85-
86-%post processes qmu results if necessary
87-if md.qmu.isdakota,
88- if ~strncmpi(getfieldvalue(options,'keep','y'),'y',1)
89- system(['rm -rf qmu' num2str(feature('GetPid'))]);
90- end
91-end
92Index: ../trunk-jpl/src/m/solve/loadresultsfromcluster.py
93===================================================================
94--- ../trunk-jpl/src/m/solve/loadresultsfromcluster.py (revision 24537)
95+++ ../trunk-jpl/src/m/solve/loadresultsfromcluster.py (revision 24538)
96@@ -76,14 +76,8 @@
97 # remove this for bin file debugging
98 TryRem('.bin', filename)
99
100- #cwd = os.getcwd().split('/')[-1]
101- if md.qmu.isdakota:
102- os.chdir('..')
103- #TryRem('', cwd)
104-
105 return md
106
107-
108 def TryRem(extension, filename):
109 try:
110 os.remove(filename + extension)
111Index: ../trunk-jpl/src/m/solve/solve.py
112===================================================================
113--- ../trunk-jpl/src/m/solve/solve.py (revision 24537)
114+++ ../trunk-jpl/src/m/solve/solve.py (revision 24538)
115@@ -152,9 +152,4 @@
116 print('loading results from cluster')
117 md = loadresultsfromcluster(md)
118
119- #post processes qmu results if necessary
120- if md.qmu.isdakota:
121- if not strncmpi(options.getfieldvalue('keep', 'y'), 'y', 1):
122- shutil.rmtree('qmu' + str(os.getpid()))
123-
124 return md
125Index: ../trunk-jpl/src/m/solve/loadresultsfromcluster.m
126===================================================================
127--- ../trunk-jpl/src/m/solve/loadresultsfromcluster.m (revision 24537)
128+++ ../trunk-jpl/src/m/solve/loadresultsfromcluster.m (revision 24538)
129@@ -45,33 +45,25 @@
130 md=loadresultsfromdisk(md,[md.miscellaneous.name '.outbin']);
131
132 %erase the log and output files
133-if md.qmu.isdakota,
134- delete([['qmu' num2str(feature('GetPid')) '/'] md.miscellaneous.name '.outlog']);
135- delete([['qmu' num2str(feature('GetPid')) '/'] md.miscellaneous.name '.errlog']);
136-else
137- if ~nolog,
138- delete([md.miscellaneous.name '.outlog']);
139- delete([md.miscellaneous.name '.errlog']);
140- end
141+if ~nolog,
142+ delete([md.miscellaneous.name '.outlog']);
143+ delete([md.miscellaneous.name '.errlog']);
144+end
145+if exist([md.private.runtimename '.outbin'])
146 delete([md.miscellaneous.name '.outbin']);
147- if exist([md.private.runtimename '.tar.gz']) & ~ispc(),
148- delete([md.private.runtimename '.tar.gz']);
149- end
150 end
151+if exist([md.private.runtimename '.tar.gz']) & ~ispc(),
152+ delete([md.private.runtimename '.tar.gz']);
153+end
154
155 %erase input file if run was carried out on same platform.
156 hostname=oshostname();
157 if strcmpi(hostname,cluster.name),
158- if md.qmu.isdakota,
159- delete([['qmu' num2str(feature('GetPid')) '/'] md.miscellaneous.name '.bin']);
160- delete([['qmu' num2str(feature('GetPid')) '/'] md.miscellaneous.name '.queue']);
161+ delete([md.miscellaneous.name '.bin']);
162+ delete([md.miscellaneous.name '.toolkits']);
163+ if ~ispc(),
164+ delete([md.miscellaneous.name '.queue']);
165 else
166- delete([md.miscellaneous.name '.bin']);
167- delete([md.miscellaneous.name '.toolkits']);
168- if ~ispc(),
169- delete([md.miscellaneous.name '.queue']);
170- else
171- delete([md.miscellaneous.name '.bat']);
172- end
173+ delete([md.miscellaneous.name '.bat']);
174 end
175 end
176Index: ../trunk-jpl/src/m/solve/solve.m
177===================================================================
178--- ../trunk-jpl/src/m/solve/solve.m (revision 24537)
179+++ ../trunk-jpl/src/m/solve/solve.m (revision 24538)
180@@ -171,10 +171,3 @@
181 elseif md.settings.waitonlock==0,
182 disp('Model results must be loaded manually with md=loadresultsfromcluster(md);');
183 end
184-
185-%post processes qmu results if necessary
186-if md.qmu.isdakota,
187- if ~strncmpi(getfieldvalue(options,'keep','y'),'y',1)
188- system(['rm -rf qmu' num2str(feature('GetPid'))]);
189- end
190-end
191Index: ../trunk-jpl/src/m/solve/loadresultsfromdisk.m
192===================================================================
193--- ../trunk-jpl/src/m/solve/loadresultsfromdisk.m (revision 24537)
194+++ ../trunk-jpl/src/m/solve/loadresultsfromdisk.m (revision 24538)
195@@ -59,5 +59,4 @@
196 %post processes qmu results if necessary
197 else
198 md=postqmu(md);
199- cd ..
200 end
Note: See TracBrowser for help on using the repository browser.