Possible bug in SEMIC-transient

wadewei

Possible bug with tmax and tmin. I haven't been able to reach out to Inwoo recently so I would just post here.

src/c/analyses/SmbAnalysis.cpp, L474-475
parameters->AddObject(iomodel->CopyConstantObject("md.smb.tmin",SmbSemicTmaxEnum));
parameters->AddObject(iomodel->CopyConstantObject("md.smb.tmax",SmbSemicTminEnum));

mathieumorlighem

Indeed this looks suspicious. Let me reach out to him

mathieumorlighem

fixed! Thanks for catching that

wadewei

mathieumorlighem
Any time Mathieu!
Another thing, though much less consequential, is the hice in SEMIC that could go negative without any control in externalpackages/semic/src/surface_physics.f90 or from ISSM side. It looks like hice isn't affecting anything, but seeing that going to -2000 m is somewhat bothering.

in-woo

wadewei

Hi, wadewei!

Did you send me the email?

I think that posting bug in this forum helps to other users. Let me know the bugs using SEMIC.

Thank you for reporting bugs.

The hice value from SEMIC is a dummy value for ISSM. This value only is used to calculate the changes of ice only in SEMIC, not used in ISSM model.

Of course, hice value can display the negative value in perspective view of SEMIC!

I think that you check SmbHSnow value, rather than SmbHIce.

If you want to prevent the negative value in hice. initialize hice` value with following code.

md.smb = SMSsemic;

# unit conversion
# ice m -> water equivalent.
# Because SEMIC calculates the mass balance based on water equivalent unit.
md.smb.hice = md.geometry.thickness * rho_ice/rho_freshwater;

Is it a right answer?

Best regards,
Inwoo

wadewei

in-woo
Hi Inwoo,
Thank you for your reply and explanation. I did write to inwoo04**@snu.ac.kr on Oct. 19. Is it still in use? Or maybe it was misclassified as spam. Don't worry about it.
Wade

in-woo

wadewei

Oh, I missed your email... Your email was not going to spam. 🙂.

Inwoo